Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terrarium - Providers]: Implementation of gRPC backend microservice integrated with DynamoDB for Data Persistence #68

Merged
merged 39 commits into from
Apr 11, 2024
Merged

[Terrarium - Providers]: Implementation of gRPC backend microservice integrated with DynamoDB for Data Persistence #68

merged 39 commits into from
Apr 11, 2024

Conversation

anjanikshree12
Copy link
Contributor

@anjanikshree12 anjanikshree12 commented Apr 2, 2024 •
edited
Loading

This PR includes:

  • protobuff definitions for provider, version manager service
  • Implementation of Version Manager Service with following functionalities:
    • To List Provider Versions (to be used by protocol apis for terraform)
    • To Get Provider's specific version's metadata (to be used by protocol apis for terraform)
    • To List Providers registered with the system (to be used by web service for UI)
    • To Get a specific provider's data (to be used by web service for UI)
    • To Register a provider with the system
    • To Publish a version (only versions that have been published should be reported to other services)
    • To Deregister a provider (using providerID & it's version) from the system.
  • Unit tests added for functions (and tested with all unit tests passing)
  • Introduced a new package for common gateway service to both modules & providers
  • Introduced a new package for common service to both modules & providers

Testing Details:

  • Metadata response as expected by the provider registry protocol:
    image
    image

  • Metadata reponse required by REST handler to be served to the UI:
    image
    image

  • UI:
    image
    image

anjanikshree12 and others added 25 commits February 19, 2024 12:16
@anjanikshree12
Implementation of the provider registry protocol v1 (#65)
cfa0cf4
changes for testing, adding a metadata for windows amd64 plat
752837f
Merge branch 'main' into CIEDEV-3005
366ccd4
removed provider stuff from docker compose that was added for testing
ad37c41
updated terraform.json
51d215a
worked on review comments
954e4fc
go fmt
c0246fb
removed unused code
daecd91
added support for v3.6.0 linux amd
cebd02e
worked on review comment suggestions
b386c43
Web ui & rest microservice for providers
11f19d5
updated pushed changes
2065d2c
merge conflicts
62f74da
go fmt
fdf7971
updatedone of the params of provider list item
60e4877
worked on review comments
27085ef
version-manager-service
833afdf
Merge branch 'main' into ciedev-3252
e971ef4
go fmt
69a0e95
update in gen proto script
672c199
correction "updating previously existing sourceUrl to sourceRepoUrl a…
b5dffae 
…s we have a sourceUrl as providerMetadata"
pushing test changes here, not the final one, this branch will be del…
2458a5d 
…eted here, as the main branch is ciedev-3252
update in version_manager
bbb1b52
adding unit tests
47401fc
removed providers.json
3cf5eaf
@anjanikshree12 anjanikshree12 self-assigned this Apr 2, 2024
adcharre
adcharre reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@adcharre adcharre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment this could have be broken into at least 2 reviews to reduce the complexity required to be reviewed in each. I would have suggested starting with the Protobuf definitions and generated files and then onto the implementation.

cmd/allInOne.go Outdated Show resolved Hide resolved
cmd/allInOne.go Outdated Show resolved Hide resolved
cmd/allInOne.go Outdated Show resolved Hide resolved
cmd/allInOne.go Outdated Show resolved Hide resolved
cmd/gateway_provider.go Outdated Show resolved Hide resolved
internal/provider/services/service.go Outdated Show resolved Hide resolved
internal/provider/services/gateway/gateway.go Outdated Show resolved Hide resolved
internal/provider/services/gateway/gateway.go Outdated Show resolved Hide resolved
internal/provider/services/gateway/gateway.go Outdated Show resolved Hide resolved
anjanikshree12 and others added 5 commits April 5, 2024 20:40
@anjanikshree12 @adcharre
Update cmd/allInOne.go
a99e603 
Co-authored-by: Adam Charrett <[email protected]>
@anjanikshree12 @adcharre
Update cmd/allInOne.go
c28d255 
Co-authored-by: Adam Charrett <[email protected]>
@anjanikshree12 @adcharre
Update cmd/gateway_provider.go
5784e3c 
Co-authored-by: Adam Charrett <[email protected]>
introduced a new package for service and common gateway for both modu…
5106004 
…les & providers, small fix in ui(source_repo_url fix), addition of span attributes, renaming of moduleServices, update in docker compose, browse cmd, allInOne, root cmds, added test functions for providers in gateway, worked for review comments
go fmt
a605ab0
@anjanikshree12 anjanikshree12 requested a review from adcharre April 6, 2024 18:48
@anjanikshree12 anjanikshree12 changed the title [Terrarium - Providers]: Implementation of gRPC backend microservice & it's integration with dynamoDB. [Terrarium - Providers]: Implementation of gRPC backend microservice integrated with DynamoDB for Data Persistence Apr 9, 2024
@anjanikshree12 anjanikshree12 requested a review from adcharre April 10, 2024 09:04
adcharre
adcharre reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@adcharre adcharre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close now - just need to add the defer span.End() to make sure all spans are closed off.

@anjanikshree12 anjanikshree12 merged commit d8616d2 into main Apr 11, 2024
1 check passed
@anjanikshree12 anjanikshree12 deleted the ciedev-3252 branch April 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcharre adcharre adcharre approved these changes

@odelanno odelanno Awaiting requested review from odelanno

Assignees

@anjanikshree12 anjanikshree12

Labels
terrarium-providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anjanikshree12 @adcharre